You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because this PR includes a bug fix, relevant tests have been included.
Because this PR includes a new feature, the change was previously discussed on an Issue or with someone from the team.
I didn't do anything of this.
This pull request introduces several optimizations to the existing e2e-tests.yml workflow to improve the overall execution time and efficiency of our end-to-end (e2e) tests on GitHub Actions as required in #5247.
Changes Introduced:
Re-enable Windows Testing:
The original workflow had Windows tests disabled due to performance issues and a bug with pnpm. We have re-enabled Windows testing with specific conditions to handle Windows-specific issues, ensuring that pnpm operations are executed correctly.
Matrix Strategy Optimization:
Ensured that the jobs are run in parallel across ubuntu-latest, macos-latest, and windows-latest, reducing the overall execution time.
Caching Dependencies:
Added caching for pnpm modules using actions/cache@v3 to avoid re-downloading and installing dependencies in every run. This change significantly reduces setup time for the jobs.
Improved Script Handling:
Introduced conditional execution of scripts based on the operating system. For non-Windows systems, the scripts are executed as before. For Windows, equivalent PowerShell scripts are used to ensure compatibility.
No testing has been performed over the current solution.
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Reason behind was PowerShell scripts references, which are not currently present in the project.
Instead of commiting the new PowerShell (.ps1) files, references about these have been removed.
Re-factored the current source-code and pushed the commit for it. @alcuadrado
Isn't this removing a comment about a bug without any reason? I don't think this has been fixed, is it?
Comment was restored as requested @alcuadrado .
Agree on the given fact. Ideally, a reference to a Github Issue should be added for properly handling the case actively.
This could be debugged in the future via https://github.com/nektos/act
Thanks once again for submitting this PR, @sisco0. Unfortunately, we won't be able to prioritize this just yet. Our CI needs are pretty different in our main development branch, so we can't put much effort into this right now.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several optimizations to the existing
e2e-tests.ymlworkflow to improve the overall execution time and efficiency of our end-to-end (e2e) tests on GitHub Actions as required in #5247.Changes Introduced:
The original workflow had Windows tests disabled due to performance issues and a bug with pnpm. We have re-enabled Windows testing with specific conditions to handle Windows-specific issues, ensuring that pnpm operations are executed correctly.
Ensured that the jobs are run in parallel across ubuntu-latest, macos-latest, and windows-latest, reducing the overall execution time.
Added caching for pnpm modules using actions/cache@v3 to avoid re-downloading and installing dependencies in every run. This change significantly reduces setup time for the jobs.
Introduced conditional execution of scripts based on the operating system. For non-Windows systems, the scripts are executed as before. For Windows, equivalent PowerShell scripts are used to ensure compatibility.
No testing has been performed over the current solution.