-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize and Enable E2E tests on Windows #5339
Optimize and Enable E2E tests on Windows #5339
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
I'm a bit confused about this PR, it fails because you are trying to run a file that doesn't exist. |
Reason behind was PowerShell scripts references, which are not currently present in the project. |
Isn't this removing a comment about a bug without any reason? I don't think this has been fixed, is it? |
Comment was restored as requested @alcuadrado . |
Thanks once again for submitting this PR, @sisco0. Unfortunately, we won't be able to prioritize this just yet. Our CI needs are pretty different in our main development branch, so we can't put much effort into this right now. |
This pull request introduces several optimizations to the existing
e2e-tests.yml
workflow to improve the overall execution time and efficiency of our end-to-end (e2e) tests on GitHub Actions as required in #5247.Changes Introduced:
The original workflow had Windows tests disabled due to performance issues and a bug with pnpm. We have re-enabled Windows testing with specific conditions to handle Windows-specific issues, ensuring that pnpm operations are executed correctly.
Ensured that the jobs are run in parallel across ubuntu-latest, macos-latest, and windows-latest, reducing the overall execution time.
Added caching for pnpm modules using actions/cache@v3 to avoid re-downloading and installing dependencies in every run. This change significantly reduces setup time for the jobs.
Introduced conditional execution of scripts based on the operating system. For non-Windows systems, the scripts are executed as before. For Windows, equivalent PowerShell scripts are used to ensure compatibility.
No testing has been performed over the current solution.